Skip to content

Specify RunContinuationsAsynchronously in DNS telemetry test #56368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MihaZupan merged 1 commit into from
Jul 27, 2021
Merged

Specify RunContinuationsAsynchronously in DNS telemetry test #56368

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/libraries/System.Net.NameResolution/tests/FunctionalTests/TelemetryTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,11 +164,13 @@ public static void ResolutionsWaitingOnQueue_ResolutionStartCalledBeforeEnqueued
using var listener = new TestEventListener("System.Net.NameResolution", EventLevel.Informational);
listener.AddActivityTracking();

TaskCompletionSource firstResolutionStart = new();
TaskCompletionSource secondResolutionStop = new();
TaskCompletionSource firstResolutionStart = new(TaskCreationOptions.RunContinuationsAsynchronously);
TaskCompletionSource secondResolutionStop = new(TaskCreationOptions.RunContinuationsAsynchronously);

List<(string EventName, Guid ActivityId)> events = new();

bool? callbackWaitTimedOut = null;

await listener.RunWithCallbackAsync(e =>
{
if (e.EventName == "ResolutionStart" || e.EventName == "ResolutionStop")
Expand All @@ -178,7 +180,7 @@ await listener.RunWithCallbackAsync(e =>

if (e.EventName == "ResolutionStart" && firstResolutionStart.TrySetResult())
{
secondResolutionStop.Task.Wait();
callbackWaitTimedOut = !secondResolutionStop.Task.Wait(TimeSpan.FromSeconds(15));
}
},
async () =>
Expand Down Expand Up @@ -219,6 +221,8 @@ static Task DoResolutionAsync()
Assert.Equal(events[0].ActivityId, events[3].ActivityId);
Assert.Equal(events[1].ActivityId, events[2].ActivityId);
Assert.NotEqual(events[0].ActivityId, events[1].ActivityId);

Assert.False(callbackWaitTimedOut);
}).Dispose();
}
}
Expand Down