Skip to content

API fix to System.Data batching API #56525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roji merged 1 commit into from
Jul 29, 2021
Merged

API fix to System.Data batching API #56525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/libraries/System.Data.Common/ref/System.Data.Common.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1945,10 +1945,10 @@ public abstract class DbBatch : System.IDisposable, System.IAsyncDisposable
public abstract class DbBatchCommand
{
public abstract string CommandText { get; set; }
public abstract CommandType CommandType { get; set; }
public abstract System.Data.CommandType CommandType { get; set; }
public abstract int RecordsAffected { get; }
public DbParameterCollection Parameters { get { throw null; } }
protected abstract DbParameterCollection DbParameterCollection { get; }
public System.Data.Common.DbParameterCollection Parameters { get { throw null; } }
protected abstract System.Data.Common.DbParameterCollection DbParameterCollection { get; }
}
public abstract class DbBatchCommandCollection : System.Collections.Generic.IList<DbBatchCommand>
{
Expand All @@ -1964,7 +1964,9 @@ public abstract class DbBatchCommandCollection : System.Collections.Generic.ILis
public abstract int IndexOf(DbBatchCommand item);
public abstract void Insert(int index, DbBatchCommand item);
public abstract void RemoveAt(int index);
public abstract DbBatchCommand this[int index] { get; set; }
public System.Data.Common.DbBatchCommand this[int index] { get { throw null; } set { throw null; } }
protected abstract System.Data.Common.DbBatchCommand GetBatchCommand(int index);
protected abstract void SetBatchCommand(int index, System.Data.Common.DbBatchCommand batchCommand);
}
public abstract partial class DbColumn
{
Expand Down
10 changes: 9 additions & 1 deletion src/libraries/System.Data.Common/src/System/Data/Common/DbBatchCommandCollection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,14 @@ public abstract class DbBatchCommandCollection : IList<DbBatchCommand>

public abstract void RemoveAt(int index);

public abstract DbBatchCommand this[int index] { get; set; }
public DbBatchCommand this[int index]
{
get => GetBatchCommand(index);
set => SetBatchCommand(index, value);
}

protected abstract DbBatchCommand GetBatchCommand(int index);

protected abstract void SetBatchCommand(int index, DbBatchCommand batchCommand);
}
}