Obsolete thumbtacked AssemblyName properties#59522
Merged
jeffhandley merged 8 commits intodotnet:mainfrom Nov 16, 2021
Merged
Conversation
ghost
added
area-System.Reflection
community-contribution
jkotas
reviewed
Sep 23, 2021
buyaa-n
reviewed
Oct 5, 2021
src/libraries/System.Private.CoreLib/src/System/Reflection/AssemblyName.cs
Outdated
Show resolved
Hide resolved
Contributor
|
Ping @i3arnon, could you address the comments? |
jeffhandley
reviewed
Nov 15, 2021
src/coreclr/System.Private.CoreLib/src/System/Reflection/AssemblyName.CoreCLR.cs
Outdated
Show resolved
Hide resolved
jeffhandley
added
the
breaking-change
ghost
added
the
needs-breaking-change-doc-created
This comment has been minimized.
This comment has been minimized.
2 tasks
This comment has been minimized.
This comment has been minimized.
jeffhandley
removed
the
needs-breaking-change-doc-created
jeffhandley
approved these changes
Nov 15, 2021
Member
|
Thanks for the contribution, @i3arnon! Please feel free to find another up-for-grabs issue if you'd like. 💯 |
This was referenced Nov 29, 2021
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #59061