Remove assert preventing empty PKCS7 exports#59812
Merged
akoeplinger merged 1 commit intodotnet:mainfrom Oct 11, 2021
Merged
Conversation
An empty PKCS7 collection is valid, so don't require the certHandles count to be greater than 0.
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks Issue DetailsAn empty PKCS7 collection is valid, so don't require the certHandles count to be greater than 0. Before: After:
|
|
Tagging subscribers to 'arch-android': @steveisok, @akoeplinger Issue DetailsAn empty PKCS7 collection is valid, so don't require the certHandles count to be greater than 0. Before: After:
|
bartonjs
approved these changes
Sep 30, 2021
steveisok
approved these changes
Sep 30, 2021
akoeplinger
approved these changes
Oct 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An empty PKCS7 collection is valid, so don't require the certHandles count to be greater than 0.
Before:
After: