Re-enable Windows test that verifies DriveInfo.VolumeLabel setter fails on SUBST'd drive

[carlossanlop]

Fixes #14027

I'm reusing code I recently added to verify SUBST with symbolic links. I moved it to its own class for virtual drive manipulation on Windows.

[ghost]

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Fixes #14027

I'm reusing code I recently added to verify SUBST with symbolic links. I moved it to its own class for virtual drive manipulation on Windows.

Author:	carlossanlop
Assignees:	carlossanlop
Labels:	area-System.IO
Milestone:	7.0.0

[carlossanlop]

Investigating this failure. I don't know why it is happening in x64 Windows Debug, since it's the one I tested locally:

 src\libraries\System.IO.FileSystem\tests\VirtualDriveSymbolicLinks.Windows.cs(14,17): error CS0246: The type or namespace name 'VirtualDriveHelper' could not be found (are you missing a using directive or an assembly reference?)

Edit: Ah, I think it's the Net5Compat test project.

[adamsitnik]

@carlossanlop could you solve the conflict?

[carlossanlop]

@jozkee @adamsitnik sorry for the delay. I resolved the conflict: Net5Compat has been recently removed, and that project was also the source of the CI failure. Can you please take a look again?

[carlossanlop]

Edit: I opened issue #62028

The CI leg runtime (Libraries Build windows net48 x86 Release) had a SourceGenerator-related failure.

.dotnet\sdk\6.0.100-rc.2.21505.57\Microsoft.Common.CurrentVersion.targets(3264,5):
error MSB3101: (NETCORE_ENGINEERING_TELEMETRY=Build)
Could not write state file
"D:\a\_work\1\s\artifacts\obj\Microsoft.Interop.SourceGeneration\netstandard2.0-Release\Microsoft.Interop.SourceGeneration.csproj.GenerateResource.cache".
The process cannot access the file
'D:\a\_work\1\s\artifacts\obj\Microsoft.Interop.SourceGeneration\netstandard2.0-Release\Microsoft.Interop.SourceGeneration.csproj.GenerateResource.cache'
because it is being used by another process.

[adamsitnik]

LGTM, I left some comments but they're all related to refactoring ideas. Thank you @carlossanlop !

[adamsitnik]

nit: you can provide multiple parameters to Combine and avoid the need of having an additional local variable

Suggested change

	string system32 = Path.Join(systemRoot, "System32");
	return Path.Join(system32, "subst.exe");
	return Path.Join(systemRoot, "System32", "subst.exe");

[carlossanlop]

You know, this could be an interesting candidate for a Roslyn Analyzer.

[carlossanlop]

#62057