Convert concatenation string to interpolation for System.Private.Xml#60057
Merged
eiriktsarpalis merged 17 commits intodotnet:mainfrom Nov 9, 2021
Merged
Conversation
ghost
added
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-xml Issue Detailsnull
|
krwq
reviewed
Oct 6, 2021
src/libraries/System.Private.Xml/src/System/Xml/Dom/DocumentXmlWriter.cs
Outdated
Show resolved
Hide resolved
am11
reviewed
Oct 6, 2021
src/libraries/System.Private.Xml/src/System/Xml/Serialization/ImportContext.cs
Outdated
Show resolved
Hide resolved
Member
|
Hi @kronic, curious why the PR was closed? |
Contributor
Author
|
@eiriktsarpalis Hello, closed by mistake |
...ibraries/System.Private.Xml/src/System/Xml/Serialization/ReflectionXmlSerializationReader.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.Xml/src/System/Xml/Serialization/XmlSerializationReaderILGen.cs
Outdated
Show resolved
Hide resolved
eiriktsarpalis
approved these changes
Oct 19, 2021
Member
eiriktsarpalis
left a comment
eiriktsarpalis
left a comment
There was a problem hiding this comment.
LGTM although might need another pair of eyes.
Contributor
Author
|
ping @eiriktsarpalis @krwq |
stephentoub
reviewed
Nov 5, 2021
Member
There was a problem hiding this comment.
Suggested change
| return $"d{_top.ToString("d", CultureInfo.InvariantCulture)}p{temp.ToString("d", CultureInfo.InvariantCulture)}"; | |
| return string.Create(CultureInfo.InvariantCulture, $"d{_top}p{temp}"; |
Contributor
Author
There was a problem hiding this comment.
@stephentoub maybe
string.Create(CultureInfo.InvariantCulture, $"d{_top:d}p{temp:d}";
stephentoub
reviewed
Nov 5, 2021
src/libraries/System.Private.Xml/src/System/Xml/Serialization/Compiler.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Nov 5, 2021
src/libraries/System.Private.Xml/src/System/Xml/Serialization/XmlSchemaExporter.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Nov 5, 2021
src/libraries/System.Private.Xml/src/System/Xml/Serialization/XmlSchemas.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Nov 5, 2021
src/libraries/System.Private.Xml/src/System/Xml/Serialization/XmlSerializationReader.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Nov 5, 2021
src/libraries/System.Private.Xml/src/System/Xml/Serialization/XmlSerializationReader.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Nov 5, 2021
src/libraries/System.Private.Xml/src/System/Xml/Serialization/XmlSerializationWriter.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Nov 5, 2021
src/libraries/System.Private.Xml/src/System/Xml/Serialization/XmlSerializationWriter.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Nov 5, 2021
src/libraries/System.Private.Xml/src/System/Xml/Serialization/XmlSerializationWriterILGen.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Nov 5, 2021
src/libraries/System.Private.Xml/src/System/Xml/Xsl/QIL/QilValidationVisitor.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Nov 5, 2021
src/libraries/System.Private.Xml/src/System/Xml/Serialization/XmlSerializationReaderILGen.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Nov 5, 2021
src/libraries/System.Private.Xml/src/System/Xml/Xsl/Runtime/XmlQueryOutput.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Nov 5, 2021
Contributor
Author
|
@stephentoub ping |
eiriktsarpalis
force-pushed
the
Convert_concatenation_to_interpolation
branch
from
a3a0ec8 to
82feb68
Compare
Member
|
Thank you @kronic! |
This was referenced Nov 29, 2021
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.