Clean up tests under Interop/PInvoke/BestFitMapping#61390
Merged
elinor-fung merged 5 commits intodotnet:mainfrom Nov 11, 2021
Merged
Clean up tests under Interop/PInvoke/BestFitMapping#61390elinor-fung merged 5 commits intodotnet:mainfrom
elinor-fung merged 5 commits intodotnet:mainfrom
Conversation
AaronRobinsonMSFT
approved these changes
Nov 10, 2021
Member
Author
|
cc @trylek - this change seems like a manual version of the test grouping you and @jkoritzinsky are working on and I think it further reinforces how much value that work would bring. |
jkoritzinsky
approved these changes
Nov 10, 2021
This was referenced Nov 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BestFitMappingAside from making my eyes bleed less when I look inside that folder, this reduces the time it takes to run the tests, time to upload results, and size of the uploaded test artifact for each PR:
@AaronRobinsonMSFT @jkoritzinsky - sorry, the diff is probably not very helpful... All the p/invoke definitions were direct copies/moved files. The existing methods for validation were nearly all the same with assorted discrepancies where some things were or were not checked, so I pulled that all out into a shared helper so that they would avoid said discrepancies without changing how/what they were validating.