Merged
Conversation
|
Tagging subscribers to this area: @dotnet/area-system-io Issue DetailsFor the description please refer to commit messages.
|
stephentoub
approved these changes
Nov 11, 2021
| public static SafeFileHandle OpenHandle(string path, FileMode mode = FileMode.Open, FileAccess access = FileAccess.Read, | ||
| FileShare share = FileShare.Read, FileOptions options = FileOptions.None, long preallocationSize = 0) | ||
| { | ||
| Strategies.FileStreamHelpers.ValidateArguments(path, mode, access, share, bufferSize: 0, options, preallocationSize); |
Member
There was a problem hiding this comment.
Nit: should FileStreamHelpers be moved out of Strategies?
| throw new ArgumentException(SR.Argument_EmptyPath, nameof(path)); | ||
| } | ||
|
|
||
| private static byte[] ReadAllBytesUnknownLength(FileStream fs) |
Member
There was a problem hiding this comment.
Did anything change in these methods, or you just moved them between files?
Member
Author
There was a problem hiding this comment.
I just moved them and I plan to send a separate PR to change them from using FileStream to RandomAccess
Member
|
Probably improved dotnet/perf-autofiling-issues#2375 (windows-x64) |
This was referenced Nov 29, 2021
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the description please refer to commit messages.