Use GeneratedDllImport for blittable p/invokes in System.Diagnostics.Process, System.Diagnostics.Process, System.Diagnostics.FileVersionInfo, System.Runtime.InteropServices.RuntimeInformation#61532
Merged
elinor-fung merged 4 commits intodotnet:mainfrom Nov 15, 2021
Conversation
13 tasks
stephentoub
reviewed
Nov 12, 2021
| <TargetFrameworks>$(NetCoreAppCurrent)-windows;$(NetCoreAppCurrent)-Unix;$(NetCoreAppCurrent)-Browser</TargetFrameworks> | ||
| <AllowUnsafeBlocks>true</AllowUnsafeBlocks> | ||
| <IgnoreForCI Condition="'$(TargetOS)' == 'Browser'">true</IgnoreForCI> | ||
| <EnableDllImportGenerator>true</EnableDllImportGenerator> |
Member
There was a problem hiding this comment.
Any reason not to just do this globally rather than per test project?
Member
Author
There was a problem hiding this comment.
We went with only doing source projects globally, since the vast majority of test projects don't need/use it and until we get everything prepped for / through API review, it would result in us adding extra files and types (some which require unsafe) to all the tests unnecessarily.
stephentoub
approved these changes
Nov 12, 2021
AaronRobinsonMSFT
approved these changes
Nov 13, 2021
elinor-fung
force-pushed
the
convertBlittable
branch
from
d4ef6d6 to
5cc51a8
Compare
This was referenced Nov 29, 2021
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @AaronRobinsonMSFT @jkoritzinsky