Fix parsing of ping error replies on raw sockets#61592
Merged
wfurt merged 3 commits intodotnet:mainfrom Nov 30, 2021
Merged
Conversation
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsFixes #61465 Needs more testing. The ICMPv4 code path was tested locally, ICMPv6 was not tested at all.
|
Member
|
LGTM it would be great IMHO to add (outerloop) test. It would need to ignore cases when there is no answer and perhaps simply test that the address is not ANY. |
Member
Author
|
Thanks for testing it. Apparently there's already similar test ( |
This was referenced Nov 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #61465