fix for excessive gen0 in high memory load situation#61884
Merged
Maoni0 merged 2 commits intodotnet:mainfrom Nov 26, 2021
Merged
fix for excessive gen0 in high memory load situation#61884Maoni0 merged 2 commits intodotnet:mainfrom
Maoni0 merged 2 commits intodotnet:mainfrom
Conversation
|
Tagging subscribers to this area: @dotnet/gc Issue Detailsin high memory load situations, when we had to wait for a BGC to finish, we switch to preemptive mode which means GCs can occur and replenished the budget. but when we come back from the wait, we use the previous decision on whether the budget was exceeded or not. this causes us to trigger GC incorrect and you would see GCs triggered when the allocated bytes are tiny. repro - when memory load is high (I made it 97%), using GC realmon this is the output - the with fix this no longer repros. also got rid of the allocations_allowed check that's unused. @PeterSolMS I did put it a bit more logic to detect whether I should do the check again. PTAL.
|
PeterSolMS
reviewed
Nov 24, 2021
PeterSolMS
reviewed
Nov 24, 2021
PeterSolMS
approved these changes
Nov 24, 2021
Contributor
PeterSolMS
left a comment
PeterSolMS
left a comment
There was a problem hiding this comment.
LGTM, but note suggestion to make it more readable...
This was referenced Nov 29, 2021
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in high memory load situations, when we had to wait for a BGC to finish, we switched to preemptive mode which means GCs could have occurred and replenished the budget. but when we come back from the wait, we use the previous decision on whether the budget was exceeded or not. this causes us to trigger GC incorrect and you would see GCs triggered when the allocated bytes are tiny.
repro -
when memory load is high (I made it 97%), using GC realmon this is the output - the
gen0 alloc (mb)column shows some gen0 GCs triggered when it's < 1mb or just a few mb instead of hundreds of mb -with fix this no longer repros.
also got rid of the allocations_allowed check that's unused.
@PeterSolMS I did put in a bit more logic to detect whether I should do the check again. PTAL.