Type memory maps with placeholders#61933
Merged
jakobbotsch merged 1 commit intodotnet:mainfrom Dec 1, 2021
Merged
Conversation
Use TYP_UNDEF (as TYP_MEM) for "first field"-like maps and TYP_UNKNOWN (as TYP_HEAP) for the heaps themselves. This will enable the type validation logic to be more precise. For now, just assert that the heap is always updated with the properly typed VNs.
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsUse This will enable the type validation logic to be more precise. For now though, just assert that the heap is always updated with the properly typed VNs. No diffs are expected...
|
Contributor
Author
|
@dotnet/jit-contrib |
jakobbotsch
reviewed
Dec 1, 2021
SingleAccretion
added a commit
to SingleAccretion/runtime
that referenced
this pull request
Dec 29, 2021
Use TYP_UNDEF (as TYP_MEM) for "first field"-like maps and TYP_UNKNOWN (as TYP_HEAP) for the heaps themselves. This will enable the type validation logic to be more precise. For now, just assert that the heap is always updated with the properly typed VNs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
TYP_UNDEF(asTYP_MEM) for "first field"-like maps andTYP_UNKNOWN(asTYP_HEAP) for the heaps themselves.This will enable the type validation logic to be more precise. For now though, just assert that the heap is always updated with the properly typed VNs.
Sample from the new dump showcasing the now-more-apparent hierarchy of maps:
No diffs.
Part of #58312.