Add RequiresDynamicCodeAttribute to runtime#61956
Conversation
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr Issue DetailsImplements the API in #61239
|
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| #nullable enable |
There was a problem hiding this comment.
This is a copypaste from RequiresUnreferencedCodeAttribute where this is likely needed because the attribute is included from multiple projects. It's not necessary here at the moment.
There was a problem hiding this comment.
I was doing some tests with the CodeFixer in the analyzer space and it generates "error CS8632: The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.". The warning disappears if I add the nullable enable statement in the attribute
There was a problem hiding this comment.
Ah I see now the Url is marked as nullable
Implements the API in #61239