[mono][interp] Remove hack for nint/nfloat#62053
Merged
akoeplinger merged 2 commits intodotnet:release/6.0-mauifrom Nov 30, 2021
Merged
[mono][interp] Remove hack for nint/nfloat#62053akoeplinger merged 2 commits intodotnet:release/6.0-mauifrom
akoeplinger merged 2 commits intodotnet:release/6.0-mauifrom
Conversation
Use a single g_print in bulk for every instruction. Otherwise, the instruction ends up being displayed on multiple lines.
These structures are valuetypes, but their mint_type is a primitive. This means that a LDFLD applied on the type would have attempted to do a pointer dereference, because it saw that the current top of stack is not STACK_TYPE_VT. This was fixed in the past by passing the managed pointer to the valuetype rather than the valuetype itself, against the normal call convention, which lead to inconsistencies in the code. This commit removes that hack and fixes the problem by ignoring LDFLD applied to nint/nfloat valuetypes in the first place.
|
Tagging subscribers to this area: @BrzVlad Issue DetailsBackport of #61612
|
Member
Author
marek-safar
approved these changes
Nov 26, 2021
Member
|
cc @rolfbjarne @Redth - fyi |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #61612