Track a missing place to reset alignment flag from BasicBlock#62163
Merged
kunalspathak merged 3 commits intodotnet:mainfrom Dec 1, 2021
Merged
Track a missing place to reset alignment flag from BasicBlock#62163kunalspathak merged 3 commits intodotnet:mainfrom
kunalspathak merged 3 commits intodotnet:mainfrom
Conversation
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsThere was a place when we reverse a conditional jump, we were not removing the
|
Contributor
Author
|
@dotnet/jit-contrib @BruceForstall |
Contributor
BruceForstall
left a comment
There was a problem hiding this comment.
LGTM.
btw, the JITDUMP in BasicBlock::unmarkLoopAlign() looks like it needs a trailing \n
BruceForstall
approved these changes
Dec 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a place when we reverse a conditional jump, we were not removing the
alignmentflag.There are some occurrences of this issue that Antigen caught over the weekend - https://dev.azure.com/dnceng/public/_build/results?buildId=1488159&view=ms.vss-build-web.run-extensions-tab