Always create the AsmDiffs zip file to upload for asmdiff pipeline#62368
Merged
kunalspathak merged 1 commit intodotnet:mainfrom Dec 3, 2021
Merged
Always create the AsmDiffs zip file to upload for asmdiff pipeline#62368kunalspathak merged 1 commit intodotnet:mainfrom
kunalspathak merged 1 commit intodotnet:mainfrom
Conversation
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsFor "no diffs" scenario, we were not uploading AsmDiffs.zip (because there is nothing to upload). But that upsets helix and the pipeline shows errors. This PR will create zip folder no matter what. See dotnet/arcade#8200 (comment) for details.
|
Contributor
Author
|
@dotnet/jit-contrib , @BruceForstall |
Contributor
Author
|
Related #61828 |
BruceForstall
approved these changes
Dec 3, 2021
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For "no diffs" scenario, we were not uploading AsmDiffs.zip (because there is nothing to upload). But that upsets helix and the pipeline shows errors. This PR will create zip folder no matter what.
See dotnet/arcade#8200 (comment) for details.