NativeAOT: Run some optimization phases twice #72539
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsIn JIT we have a debug-only mode where we can run some optimization phases multiple times. It feels to me that we can enable it for NativeAOT even in Release. And I have a feeling that it should bring some nice diffs (probably needs jit-utils for proper diffs) - let's see what CI thinks about it. E.g in #70907 I've got nice diffs by simply running optRedundantBranches twice.
|
Member
Author
|
Ah, optRepeat seems to be broken - a lot of various asserts, but I still think it's worth a try someday |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In JIT we have a debug-only mode where we can run some optimization phases multiple times. It feels to me that we can enable it for NativeAOT even in Release. And I have a feeling that it should bring some nice diffs (probably needs jit-utils for proper diffs) - let's see what CI thinks about it.
E.g in #70907 I've got nice diffs by simply running optRedundantBranches twice.
PS: not for net 7.0