Redisable GetAndSet_AreThreadSafe_AndUpdatesNeverLeavesNullValues test#72882
Merged
danmoseley merged 2 commits intodotnet:mainfrom Jul 27, 2022
Merged
Redisable GetAndSet_AreThreadSafe_AndUpdatesNeverLeavesNullValues test#72882danmoseley merged 2 commits intodotnet:mainfrom
danmoseley merged 2 commits intodotnet:mainfrom
Conversation
Member
Author
|
As to why -- my first thought was that the write to readValueIsNull needs to be volatile. But the assert is that it's false. (Plus, @stephentoub pointed out that the write cannot move past IsCancellationRequested as it does a volatile read, and the read cannot move before WaitAny as it performs a memory barrier). There is likely a memory incorrectness issue in the cache. Test was originally modified to the current form here: aspnet/Caching@21c850a#diff-2b1f7c7cf3a8b8b4966f4a7fe85e10172f283fb96af85693cc7d30f923ee7dbaR444 in case that's relevant next time this is looked at. |
jakobbotsch
approved these changes
Jul 26, 2022
maryamariyan
approved these changes
Jul 26, 2022
Member
Author
I'll open a bug for that, and disable those tests again as well. They need rewriting. I just exposed this issue. edit: disabled against #72890 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #72879
Seems to be only reproing on Arm, and if that's the case would explain why I could not repro it.