JIT: refactor and enhance the redundant branch optimizer#76207
Merged
AndyAyersMS merged 1 commit intodotnet:mainfrom Sep 27, 2022
Merged
JIT: refactor and enhance the redundant branch optimizer#76207AndyAyersMS merged 1 commit intodotnet:mainfrom
AndyAyersMS merged 1 commit intodotnet:mainfrom
Conversation
One more preparatory step before introducing the new phi-based disambiguation. * handle some cases of ambiguous preds better * split out the jump threading pre checks into a helper * properly support updating switch preds * generalize retry logic a bit to handle more cases
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsOne more preparatory step before introducing the new phi-based disambiguation.
|
Member
Author
|
@EgorBo PTAL Mostly improved diffs, but some regressions where LSRA strategy changes (different spills and/or prolog/epilog changes). Retries should have minimal TP impact. |
Member
🎉 |
Member
Author
|
@EgorBo you approve? |
EgorBo
approved these changes
Sep 27, 2022
Member
EgorBo
left a comment
EgorBo
left a comment
There was a problem hiding this comment.
Nice diffs from a refactoring 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One more preparatory step before introducing the new phi-based disambiguation.
Diffs