[ARM64] Add g_GCShadowEnd to JIT_WriteBarrier_Table#91342
Merged
jkotas merged 4 commits intodotnet:mainfrom Sep 1, 2023
Merged
[ARM64] Add g_GCShadowEnd to JIT_WriteBarrier_Table#91342jkotas merged 4 commits intodotnet:mainfrom
jkotas merged 4 commits intodotnet:mainfrom
Conversation
This change moves address of g_GCShadowEnd to JIT_WriteBarrier_Table like others variables used in Write Barrier. This fix simmilar to RISC-V one dotnet#90036
ghost
added
community-contribution
jkotas
reviewed
Aug 30, 2023
src/coreclr/vm/arm64/asmhelpers.asm
Outdated
Comment on lines
+350
to
+353
| wbs_GCShadow | ||
| DCQ 0 | ||
| wbs_GCShadowEnd | ||
| DCQ 0 |
Member
There was a problem hiding this comment.
Could you please move wbs_GCShadow and wbs_GCShadowEnd to the end of the wbs block? These are debug-only fields, having them at the end would be a tiny bit better for cache locality.
Maoni0
approved these changes
Aug 31, 2023
Member
Maoni0
left a comment
Maoni0
left a comment
There was a problem hiding this comment.
LGTM, thanks for doing this work!
This was referenced Aug 31, 2023
Member
|
Build errors: |
jkotas
reviewed
Sep 1, 2023
jkotas
reviewed
Sep 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change moves address of g_GCShadowEnd to JIT_WriteBarrier_Table like others variables used in Write Barrier.
This fix simmilar to RISC-V one #90036
cc @jakobbotsch @Maoni0 @wscho77 @HJLeee @JongHeonChoi @t-mustafin @clamp03 @gbalykov @tomeksowi