Skip to content

JIT: Remove fgExpandQmarkForCastInstOf#98610

Merged
EgorBo merged 2 commits intodotnet:mainfrom
EgorBo:more-casts-4
Feb 19, 2024
Merged

JIT: Remove fgExpandQmarkForCastInstOf#98610
EgorBo merged 2 commits intodotnet:mainfrom
EgorBo:more-casts-4

Conversation

@EgorBo
Copy link
Member

@EgorBo EgorBo commented Feb 17, 2024

@ghost ghost assigned EgorBo Feb 17, 2024
@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 17, 2024
@ghost
Copy link

ghost commented Feb 17, 2024

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Another attempt, this time should be with size wins.

Author: EgorBo
Assignees: EgorBo
Labels:

area-CodeGen-coreclr

Milestone: -

@EgorBo EgorBo marked this pull request as ready for review February 17, 2024 20:13
@EgorBo EgorBo requested a review from jakobbotsch February 19, 2024 10:36
@EgorBo
Copy link
Member Author

EgorBo commented Feb 19, 2024

@jakobbotsch cc @dotnet/jit-contrib PTAL

The only missing case now is isinst Class<_Canon> - the problem is to extract Class from the runtime lookup in a late phase. For that I'll have to move the whole phase into the place where I still can rely on VNs.

Diffs

@EgorBo EgorBo merged commit 5a45ea0 into dotnet:main Feb 19, 2024
@EgorBo EgorBo deleted the more-casts-4 branch February 19, 2024 20:16
@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants