Don't place unconstructed EETypes in the types hashtable#1319
Merged
MichalStrehovsky merged 1 commit intodotnet:feature/NativeAOTfrom Jul 13, 2021
Merged
Don't place unconstructed EETypes in the types hashtable#1319MichalStrehovsky merged 1 commit intodotnet:feature/NativeAOTfrom
MichalStrehovsky merged 1 commit intodotnet:feature/NativeAOTfrom
Conversation
We shouldn't need to see the unconstructed types at runtime for anything. Fixes dotnet#1262.
jkotas
approved these changes
Jul 13, 2021
Member
jkotas
left a comment
There was a problem hiding this comment.
Thanks. Does the linked issue fail with missing metadata exception now?
Member
Author
Yup: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We shouldn't need to see the unconstructed types at runtime for anything.
Fixes #1262.