Skip to content

[Swift bindings] Upgrade dotnet runtime version to 9.0.0#2879

Merged
kotlarmilos merged 8 commits intofeature/swift-bindingsfrom
swift-bindings/upgrade-dotnet-9.0.0
Dec 17, 2024
Merged

[Swift bindings] Upgrade dotnet runtime version to 9.0.0#2879
kotlarmilos merged 8 commits intofeature/swift-bindingsfrom
swift-bindings/upgrade-dotnet-9.0.0

Conversation

@kotlarmilos
Copy link
Copy Markdown
Member

Description

This PR upgrades the runtime to version 9.0.0, along with additional changes from arcade.

The ./build.sh script installs the new version of dotnet locally in the .dotnet directory. When running dotnet test, it doesn't automatically detect the local version. To resolve this, add the directory to the path: export PATH="./.dotnet:$PATH".

dotnet-maestro bot and others added 8 commits November 4, 2024 09:43
…101.1 (#2747)

Microsoft.DotNet.Arcade.Sdk
 From Version 10.0.0-beta.24515.3 -> To Version 10.0.0-beta.24551.1

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…110.1 (#2763)

Microsoft.DotNet.Arcade.Sdk
 From Version 10.0.0-beta.24551.1 -> To Version 10.0.0-beta.24560.1

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…114.1 (#2784)

Microsoft.DotNet.Arcade.Sdk
 From Version 10.0.0-beta.24560.1 -> To Version 10.0.0-beta.24564.1

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…122.3 (#2808)

Microsoft.DotNet.Arcade.Sdk
 From Version 10.0.0-beta.24564.1 -> To Version 10.0.0-beta.24572.3

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…128.2 (#2819)

Microsoft.DotNet.Arcade.Sdk
 From Version 10.0.0-beta.24572.3 -> To Version 10.0.0-beta.24578.2

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…206.6 (#2865)

Microsoft.DotNet.Arcade.Sdk
 From Version 10.0.0-beta.24578.2 -> To Version 10.0.0-beta.24606.6

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
# Skip brew update for now, see https://github.com/actions/setup-python/issues/577
# brew update --preinstall
brew bundle --no-upgrade --no-lock --file=- <<EOF
brew "cmake"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to talk to @mandel-macaque about this. I don't know the current state of things, but my understanding is that there are some issues around using brew

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an arcade change and I don't think our CI relies on it.

@kotlarmilos kotlarmilos merged commit 73257f6 into feature/swift-bindings Dec 17, 2024
@kotlarmilos kotlarmilos deleted the swift-bindings/upgrade-dotnet-9.0.0 branch December 17, 2024 15:57
@jkurdek
Copy link
Copy Markdown

jkurdek commented Dec 17, 2024

Why did this bump the .NET SDK version to .NET 10? was this necessary?

@kotlarmilos
Copy link
Copy Markdown
Member Author

It is not necessary, but it is nice to have. Transitioning between different .NET versions in BTfS was a non-trivial task. Now, we can avoid this by performing periodic upgrades. The arcade changes are not automated on this branch, so we manually sync it with our base branch (standalone-template).

@jkurdek
Copy link
Copy Markdown

jkurdek commented Dec 18, 2024

I understand that this is nice to have, however I'm not sure whether it is worth it. For example bumping SDK version to .NET 10 broke my vscode dev kit, making local development a bit of a pain. Have you tested this scenario before the the bump?

@kotlarmilos
Copy link
Copy Markdown
Member Author

I haven't tested it with vscode devkit. Is that a known issue in .NET 10? Our CI pipeline includes tests, but it does not include the devkit.

@kotlarmilos
Copy link
Copy Markdown
Member Author

This was a vscode issue similar to microsoft/vscode-dotnettools#808.

Going forward, we will test such changes on multiple contributors' machines before merging them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-SwiftBindings Swift bindings for .NET

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants