Produce reference assembly when target is .NET Standard#30792
Closed
drewnoakes wants to merge 1 commit intodotnet:mainfrom
Closed
Produce reference assembly when target is .NET Standard#30792drewnoakes wants to merge 1 commit intodotnet:mainfrom
drewnoakes wants to merge 1 commit intodotnet:mainfrom
Conversation
In general we want to produce reference assemblies whenever possible, as they improve incremental build performance. However they require support from other components, such as the fast up-to-date check in VS. While support was originally added for SDK-style projects, it was not present for legacy `.csproj` files. Accordingly, `ProduceReferenceAssemblies` was set `true` only when the target framework was `net5.0` or later (and `net7.0` for F#). VS 17.5 ships the new Build Acceleration feature, which works best when used in conjunction with reference assemblies. A customer reported in dotnet/project-system#8865 that builds in their .NET Standard projects were not accelerated. Investigation shows this is because reference assemblies are not produced for such projects. This change enables the production of reference assemblies for all (non-F#) projects targeting .NET Standard.
Member
|
As of F# 7 (shipped with .NET 7) F# supports producing reference assemblies. @vzarytovskii should it also be enabled here for libraries? |
Member
We can enable them by default, yeah. It's targeting NET8p2, right? |
Member
|
@drewnoakes per offline discussion, was the decision to change this in msbuild instead and then update these tests when that flows? |
Member
Author
|
@marcpopMSFT yes, the proposed MSBuild change is here: dotnet/msbuild#8571 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In general we want to produce reference assemblies whenever possible, as they improve incremental build performance.
Making them work end-to-end requires support from other components, such as the fast up-to-date check in VS. While support was originally added for SDK-style projects, it was not present for legacy
.csprojfiles. Accordingly,ProduceReferenceAssemblieswas settrueonly when the target framework wasnet5.0or later (andnet7.0for F#).VS 17.5 ships the new Build Acceleration feature, which works best when used in conjunction with reference assemblies. A customer reported in dotnet/project-system#8865 that builds in their .NET Standard projects were not accelerated. Investigation shows this is because reference assemblies are not produced for such projects.
This change enables the production of reference assemblies for all (non-F#) projects targeting .NET Standard.