[release/10.0.1xx] URL-encode scoped CSS Link headers for non-ASCII project names by Copilot · Pull Request #51039 · dotnet/sdk

Copilot · 2025-09-27T11:07:19Z

URL-encode scoped CSS Link headers for non-ASCII project names

Description

Blazor apps with non-ASCII project names (e.g. 中文) failed at runtime due to raw non-ASCII characters in generated Link headers for scoped CSS bundles.

Fixes #51038

Customer Impact

This is required to be compliant with GB18030 and deal with cases where project names use non-ascii characters.

Regression?

Yes
No

9.0

Risk

High
Medium
Low

Updates the manifest generation logic to ensure we URL encode path segments on the Link header. No other header that we emit needs this treatment.

Verification

Manual (required)
Automated

Packaging changes reviewed?

Yes
No
N/A

javiercn

@copilot address the feedback and make sure you don't modify unrelated files.

src/StaticWebAssetsSdk/Targets/Microsoft.NET.Sdk.StaticWebAssets.ScopedCss.targets

javiercn · 2025-09-27T12:19:56Z

test/Microsoft.NET.Sdk.StaticWebAssets.Tests/ComputeStaticWebAssetsTargetPathsTest.cs

Unrelated change. Undo

test/Microsoft.NET.Sdk.StaticWebAssets.Tests/JsModulesIntegrationTest.cs

test/Microsoft.NET.Sdk.StaticWebAssets.Tests/LegacyStaticWebAssetsV1IntegrationTest.cs

test/Microsoft.NET.Sdk.StaticWebAssets.Tests/StaticWebAssetEndpointsIntegrationTest.cs

test/Microsoft.NET.Sdk.StaticWebAssets.Tests/StaticWebAssetsBaselineFactory.cs

test/Microsoft.NET.Sdk.StaticWebAssets.Tests/StaticWebAssetsCompressionIntegrationTest.cs

test/Microsoft.NET.Sdk.StaticWebAssets.Tests/StaticWebAssetsFingerprintingTest.cs

test/Microsoft.NET.Sdk.StaticWebAssets.Tests/StaticWebAssetsIntegrationTest.cs

test/Microsoft.NET.Sdk.StaticWebAssets.Tests/ScopedCssIntegrationTests.cs

Copilot · 2025-09-27T12:41:31Z

@copilot address the feedback and make sure you don't modify unrelated files.

Addressed feedback in commit 9e13d45:

Reverted unnecessary RelativePath URL encoding changes (lines 235-241)
Reverted all unrelated test file formatting changes
Updated test to use proper RazorAppWithPackageAndP2PReference structure with library dependency named "项目"
Only the Link header value is now URL-encoded as requested

src/StaticWebAssetsSdk/Targets/Microsoft.NET.Sdk.StaticWebAssets.ScopedCss.targets

src/StaticWebAssetsSdk/Tasks/GenerateStaticWebAssetEndpointsManifest.cs

javiercn · 2025-09-29T09:46:56Z

There seems to be this unrelated test failure that seems to be failing pretty consistently Microsoft.NET.Publish.Tests.GivenThatWeWantToPublishAnAotApp.Microsoft.NET.Publish.Tests.GivenThatWeWantToPublishAnAotApp.NativeAot_hw_fails_with_unsupported_host_rid(targetFramework: "net10.0")

ilonatommy

Tested with dogfood sdk script and blazor app.

ilonatommy · 2025-09-29T13:03:54Z

All failures are marked as known build errors but build analysis does not want to get green.

ilonatommy · 2025-09-29T13:05:04Z

/ba-g build analysis should be green, all failures are known

…ct names Co-authored-by: javiercn <6995051+javiercn@users.noreply.github.com>

Co-authored-by: javiercn <6995051+javiercn@users.noreply.github.com>

…er project structure Co-authored-by: javiercn <6995051+javiercn@users.noreply.github.com>

Co-authored-by: javiercn <6995051+javiercn@users.noreply.github.com>

lewing · 2025-10-01T19:57:35Z

approved in email

src/StaticWebAssetsSdk/Tasks/GenerateStaticWebAssetEndpointsManifest.cs

tarekgh · 2025-10-01T20:06:19Z

src/StaticWebAssetsSdk/Tasks/GenerateStaticWebAssetEndpointsManifest.cs

+    {
+        var index = header.IndexOf('<');
+        if (index == -1)
+        {


nit, better to make this index < 0

tarekgh · 2025-10-01T20:06:39Z

src/StaticWebAssetsSdk/Tasks/GenerateStaticWebAssetEndpointsManifest.cs

+        index++;
+        var endIndex = header.IndexOf('>', index);
+        if (endIndex == -1)
+        {


…307-ed00dbbcd48e

@KalleOlaviNiemitalo

…st (#12572) Resolves #12571 This PR adds `System.Uri::EscapeDataString` (and `UnescapeDataString`) to the MSBuild property function allowlist, enabling developers to properly escape URI components in MSBuild projects without needing to resort to workarounds with `UriBuilder.Path`. ## Problem Previously, developers who needed to URL-encode strings in MSBuild had to use workarounds like manipulating `UriBuilder.Path`, which is not semantically correct and error-prone. The `System.Uri::EscapeDataString` method is the standard .NET approach for encoding URI data components. ## Solution Added `System.Uri` to the `AvailableStaticMethods` allowlist in `Constants.cs`, which enables all static methods on the `System.Uri` class including `EscapeDataString` and `UnescapeDataString`. ## Usage ```xml <PropertyGroup> <QueryParam>hello world & test=123</QueryParam> <EscapedParam>$([System.Uri]::EscapeDataString($(QueryParam)))</EscapedParam>  </PropertyGroup> ``` ## Safety `System.Uri::EscapeDataString` is a pure function with no side effects, making it completely safe for use during project evaluation. It follows the same security model as other allowed static methods like `System.String` and `System.Convert`. ## Testing - Added comprehensive unit test verifying the functionality works correctly - Verified round-trip encoding/decoding with various input types - Confirmed all existing tests continue to pass (27/27 intrinsic function tests) - Validated that existing `UriBuilder` functionality remains unaffected This change provides a clean, semantically correct way to handle URI encoding in MSBuild without breaking any existing functionality.  <details> <summary>Original prompt</summary> > > ---- > > *This section details on the original issue you should resolve* > > <issue_title>Instead of hacking with UriBuilder.Path, I think it would be better to add `[System.Uri]::EscapeDataString` to the allowlist at the MSBuild side.</issue_title> > <issue_description>Instead of hacking with UriBuilder.Path, I think it would be better to add `[System.Uri]::EscapeDataString` to the allowlist at the MSBuild side. > > _Originally posted by @KalleOlaviNiemitalo in dotnet/sdk#51039 (comment) > > We should allow this method on the set of known functions. It's available across framework and modern .NET. </issue_description> > > ## Comments on the Issue (you are @copilot in this section) > > <comments> > </comments> > </details> Fixes #12571  --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: baronfel <573979+baronfel@users.noreply.github.com>

Copilot AI assigned Copilot and javiercn Sep 27, 2025

Copilot started work on behalf of javiercn September 27, 2025 11:07 View session

Copilot AI changed the title ~~[WIP] [ASP.NET] Scoped CSS should URL encode the link header~~ Fix scoped CSS URL encoding for non-ASCII project names Sep 27, 2025

Copilot AI requested a review from javiercn September 27, 2025 11:33

Copilot finished work on behalf of javiercn September 27, 2025 11:33

javiercn reviewed Sep 27, 2025

View reviewed changes

Copilot started work on behalf of javiercn September 27, 2025 12:32 View session

Copilot AI requested a review from javiercn September 27, 2025 12:46

Copilot finished work on behalf of javiercn September 27, 2025 12:46

KalleOlaviNiemitalo reviewed Sep 27, 2025

View reviewed changes

src/StaticWebAssetsSdk/Targets/Microsoft.NET.Sdk.StaticWebAssets.ScopedCss.targets Outdated Show resolved Hide resolved

baronfel mentioned this pull request Sep 27, 2025

Instead of hacking with UriBuilder.Path, I think it would be better to add [System.Uri]::EscapeDataString to the allowlist at the MSBuild side. dotnet/msbuild#12571

Closed

Copilot AI mentioned this pull request Sep 27, 2025

Add System.Uri::EscapeDataString to MSBuild property function allowlist dotnet/msbuild#12572

Merged

javiercn reviewed Sep 27, 2025

View reviewed changes

src/StaticWebAssetsSdk/Tasks/GenerateStaticWebAssetEndpointsManifest.cs Show resolved Hide resolved

javiercn marked this pull request as ready for review September 27, 2025 18:30

ilonatommy approved these changes Sep 29, 2025

View reviewed changes

maraf approved these changes Sep 29, 2025

View reviewed changes

ilonatommy mentioned this pull request Sep 29, 2025

The command output did not contain expected result: error NETSDK1204 #51049

Closed

javiercn changed the title ~~Fix scoped CSS URL encoding for non-ASCII project names~~ URL-encode scoped CSS Link headers for non-ASCII project names Sep 29, 2025

lewing added the Servicing-consider label Sep 29, 2025

Copilot AI and others added 2 commits September 30, 2025 11:52

URL encode PackageId in scoped CSS asset paths to fix non-ASCII proje…

0e1881a

…ct names Co-authored-by: javiercn <6995051+javiercn@users.noreply.github.com>

Final verification that URL encoding fix works correctly

dec378b

Co-authored-by: javiercn <6995051+javiercn@users.noreply.github.com>

Copilot AI and others added 4 commits September 30, 2025 11:52

Address feedback: revert unnecessary changes and fix test to use prop…

f44a784

…er project structure Co-authored-by: javiercn <6995051+javiercn@users.noreply.github.com>

Fix syntax error in test method

21a64d7

Co-authored-by: javiercn <6995051+javiercn@users.noreply.github.com>

fix test

8555444

Fix encoding when generating the manifest instead

95dcef5

javiercn force-pushed the copilot/fix-43cc9698-4150-4c8c-a307-ed00dbbcd48e branch from 69393b7 to 95dcef5 Compare September 30, 2025 09:52

lewing added this to the 10.0.1xx milestone Sep 30, 2025

lewing changed the title ~~URL-encode scoped CSS Link headers for non-ASCII project names~~ [release/10.0.1xx] URL-encode scoped CSS Link headers for non-ASCII project names Sep 30, 2025

lewing approved these changes Oct 1, 2025

View reviewed changes

lewing added Servicing-approved and removed Servicing-consider labels Oct 1, 2025

tarekgh reviewed Oct 1, 2025

View reviewed changes

src/StaticWebAssetsSdk/Tasks/GenerateStaticWebAssetEndpointsManifest.cs Show resolved Hide resolved

tarekgh reviewed Oct 1, 2025

View reviewed changes

Merge branch 'release/10.0.1xx' into copilot/fix-43cc9698-4150-4c8c-a…

8704787

…307-ed00dbbcd48e

lewing enabled auto-merge (squash) October 1, 2025 22:48

lewing merged commit 95d125e into release/10.0.1xx Oct 2, 2025
26 of 27 checks passed

lewing deleted the copilot/fix-43cc9698-4150-4c8c-a307-ed00dbbcd48e branch October 2, 2025 00:16

javiercn mentioned this pull request Oct 3, 2025

[ASP.NET] Scoped CSS should URL encode the link header #51038

Closed

dotnet-maestro bot mentioned this pull request Dec 9, 2025

[main] Source code updates from dotnet/sdk dotnet/dotnet#3754

Merged

Conversation

Copilot AI commented Sep 27, 2025 • edited by javiercn Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

URL-encode scoped CSS Link headers for non-ASCII project names

Description

Customer Impact

Regression?

Risk

Verification

Packaging changes reviewed?

Uh oh!

javiercn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

javiercn Sep 27, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Sep 27, 2025

Uh oh!

Uh oh!

Uh oh!

javiercn commented Sep 29, 2025

Uh oh!

ilonatommy left a comment

Choose a reason for hiding this comment

Uh oh!

ilonatommy commented Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ilonatommy commented Sep 29, 2025

Uh oh!

lewing commented Oct 1, 2025

Uh oh!

Uh oh!

tarekgh Oct 1, 2025

Choose a reason for hiding this comment

Uh oh!

tarekgh Oct 1, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Copilot AI commented Sep 27, 2025 •

edited by javiercn

Loading

ilonatommy commented Sep 29, 2025 •

edited

Loading