Skip to content

Add maui to source index#178

Merged
joperezr merged 1 commit intomainfrom
joperezr-patch-1
Dec 17, 2024
Merged

Add maui to source index#178
joperezr merged 1 commit intomainfrom
joperezr-patch-1

Conversation

@joperezr
Copy link
Copy Markdown
Member

@ericstj
Copy link
Copy Markdown
Member

ericstj commented Dec 11, 2024

Did you want to schedule a validation build to test this?

@ericstj
Copy link
Copy Markdown
Member

ericstj commented Dec 11, 2024

@rmarinho
Copy link
Copy Markdown
Member

We might need to tweak some artifacts folder we see there or is that normal ?
Screenshot 2024-12-11 at 22 54 13

@rmarinho
Copy link
Copy Markdown
Member

I also think it s missing our platform code with specific iOS or android target framework. Does the tool support that?

@joperezr
Copy link
Copy Markdown
Member Author

We might need to tweak some artifacts folder we see there or is that normal ?

Do you mean the fact that the artifacts folder is visible to begin with or some of its contents? The fact that is visible is normal I believe, as I see it for other repos as well.

@joperezr
Copy link
Copy Markdown
Member Author

I also think it s missing our platform code with specific iOS or android target framework. Does the tool support that?

No, the tool only allows to target a single configuration

@rmarinho
Copy link
Copy Markdown
Member

Ok I think we can merge this if possible.

@joperezr joperezr merged commit d6d6c4b into main Dec 17, 2024
@ericstj
Copy link
Copy Markdown
Member

ericstj commented Dec 17, 2024

LGTM

@ericstj ericstj deleted the joperezr-patch-1 branch December 17, 2024 22:54
@ericstj ericstj restored the joperezr-patch-1 branch December 17, 2024 22:54
@akoeplinger akoeplinger deleted the joperezr-patch-1 branch April 25, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants