add review comment to sb files#1038
Merged
tmat merged 1 commit intodotnet:mainfrom Jun 12, 2023
Merged
Conversation
26 tasks
Contributor
Author
|
@tmat soft ping - would be great if you could take a look at this small PR. Thank you! |
tmat
approved these changes
Jun 12, 2023
Member
|
Wanna add .github/CODEOWNERS file? E.g. https://github.com/dotnet/aspnetcore/blob/main/.github/CODEOWNERS |
Contributor
Author
Originally I wanted to add both the comments and the If you are OK with grating write access to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to dotnet/source-build#3435
Adds comments to source-build files asking for the inclusion of the source-build team in PRs that alter
SourceBuild*files. Non-reviewed changes could potentially cause issues down the line, be it in the downstream repos or the product build (as has happened in the past, see dotnet/source-build#3435 (comment))