Skip to content

Update dependencies and enable nuget audit (direct mode) #1358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ViktorHofer merged 2 commits into from
Feb 3, 2025
Merged

Update dependencies and enable nuget audit (direct mode) #1358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfeda7e
Update dependencies to avoid referencing vulnerable dependencies
ViktorHofer Jan 30, 2025
1029aff
Enable NuGet Audit (direct dependencies only)
ViktorHofer Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions NuGet.config
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,8 @@
<disabledPackageSources>
<clear />
</disabledPackageSources>
<auditSources>
<clear />
<add key="nuget.org" value="https://api.nuget.org/v3/index.json" />
</auditSources>
</configuration>
10 changes: 5 additions & 5 deletions eng/BuildTask.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,11 +87,11 @@

<!-- Desktop MSBuild compatibilty -->
<ItemGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETFramework'">
<PackageReference Update="System.Text.Json" Version="7.0.1" />
<PackageReference Update="Microsoft.Extensions.Logging.Console" Version="7.0.0" />
<PackageReference Update="Microsoft.Extensions.DependencyModel" Version="7.0.0" />
<PackageReference Update="System.Collections.Immutable" Version="7.0.0" />
<PackageReference Update="System.Reflection.Metadata" Version="7.0.0" />
<PackageReference Update="System.Text.Json" Version="8.0.5" />
<PackageReference Update="Microsoft.Extensions.Logging.Console" Version="8.0.1" />
<PackageReference Update="Microsoft.Extensions.DependencyModel" Version="8.0.2" />
<PackageReference Update="System.Collections.Immutable" Version="8.0.0" />
<PackageReference Update="System.Reflection.Metadata" Version="8.0.1" />
</ItemGroup>

<!-- Publish .NET assets and include them in the package under tools/net directory. -->
Expand Down
4 changes: 2 additions & 2 deletions eng/Versions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@
<MicrosoftBuildTasksCoreVersion>17.8.3</MicrosoftBuildTasksCoreVersion>
<MicrosoftIORedistVersion>6.0.1</MicrosoftIORedistVersion>
<!-- nuget -->
<NuGetVersioningVersion>5.7.0</NuGetVersioningVersion>
<NuGetVersioningVersion>6.12.1</NuGetVersioningVersion>
<!-- runtime -->
<SystemTextJsonVersion>7.0.3</SystemTextJsonVersion>
<SystemTextJsonVersion>8.0.5</SystemTextJsonVersion>
</PropertyGroup>
</Project>
3 changes: 3 additions & 0 deletions src/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@
<GenerateResxSource>true</GenerateResxSource>

<IncludeSymbols Condition="'$(DebugType)' != 'embedded' and '$(UsingMicrosoftNoTargetsSdk)' != 'true'">true</IncludeSymbols>

<!-- Only upgrade NuGetAudit warnings to errors for official builds. -->
<WarningsNotAsErrors Condition="'$(OfficialBuild)' != 'true'">$(WarningsNotAsErrors);NU1901;NU1902;NU1903;NU1904</WarningsNotAsErrors>
</PropertyGroup>

</Project>
2 changes: 1 addition & 1 deletion src/SourceLink.Tools/Microsoft.SourceLink.Tools.Package.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,6 @@
<NoWarn>$(NoWarn);NU5128</NoWarn>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="System.Text.Json" />
<PackageReference Include="System.Text.Json" Condition="'$(TargetFrameworkIdentifier)' != '.NETCoreApp'" />
</ItemGroup>
</Project>