Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
RussKie
approved these changes
Dec 10, 2020
Codecov Report
@@ Coverage Diff @@
## master #4342 +/- ##
===================================================
- Coverage 97.96404% 97.95639% -0.00765%
===================================================
Files 537 537
Lines 261498 261498
Branches 4815 4815
===================================================
- Hits 256174 256154 -20
- Misses 4452 4468 +16
- Partials 872 876 +4
Flags with carried forward coverage won't be shown. Click here to find out more. |
Contributor
|
Thank you |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4213
Proposed changes
Do not perform an exact check on the number of invalidations since the OS may perform additional invalidations. See issue for a detailed analysis of the scenario we are fixing.
Customer Impact
none, test-only
Regression?
no
Risk
none, test-only
Before
Test failed depending on last input, which was indeterministic due to multithreaded tests simulating user input.
After
Test should be stable independent of input generated by other threads
Test methodology
Run the test in the VS debugger and make sure its independent of keyboard/mouse input performed in the debugger
Microsoft Reviewers: Open in CodeFlow