Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR adds non-empty filename validation to both DownloadFromStream and DownloadFromUrl, removes obsolete .NET version directives in the stream download logic, and includes the missing System namespace import. Class diagram for updated Download component methodsclassDiagram
class DownloadOption {
+string FileName
+Stream FileStream
+string Url
}
class Download {
+Task DownloadFromStream(DownloadOption option)
+Task DownloadFromUrl(DownloadOption option)
}
Download --> DownloadOption: uses
Flow diagram for filename validation in download methodsflowchart TD
A[Start DownloadFromStream or DownloadFromUrl] --> B{Is FileName null or empty?}
B -- Yes --> C[Throw InvalidOperationException]
B -- No --> D[Proceed with download logic]
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6568 +/- ##
===========================================
- Coverage 100.00% 99.98% -0.02%
===========================================
Files 719 719
Lines 31560 31566 +6
Branches 4450 4452 +2
===========================================
Hits 31560 31560
- Misses 0 4 +4
- Partials 0 2 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Aug 15, 2025
This was referenced Aug 22, 2025
This was referenced Sep 3, 2025
This was referenced Sep 11, 2025
This was referenced Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #6567
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Enforce non-null FileName in Download component and remove obsolete NET5_0 conditional logic
Bug Fixes:
Enhancements: