Conversation
Contributor
Reviewer's GuideThis PR introduces asynchronous click support for LinkButton by refactoring the click handler into the base component (ButtonBase), enhancing OnClickButton to manage loading/disabled states when IsAsync is enabled, and updating unit tests to cover async behavior. Sequence diagram for LinkButton async click handlingsequenceDiagram
participant User as actor
participant LinkButton
participant ButtonBase
User->>LinkButton: Clicks button
LinkButton->>LinkButton: If IsAsync, set IsAsyncLoading/IsDisabled
LinkButton->>ButtonBase: HandlerClick()
ButtonBase->>ButtonBase: OnClickWithoutRender/OnClick
LinkButton->>LinkButton: If IsAsync, restore IsDisabled/IsAsyncLoading
Class diagram for updated ButtonBase and LinkButton async click supportclassDiagram
class ButtonBase {
+OnClickWithoutRender
+OnClick
+IsAsync
+IsNotRender
+HandlerClick()
}
class LinkButton {
+IsAsyncLoading
+IsDisabled
+IsKeepDisabled
+OnClickButton()
}
ButtonBase <|-- LinkButton
ButtonBase : +HandlerClick() (moved from Button)
LinkButton : +OnClickButton() (updated for async)
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `src/BootstrapBlazor/Components/Button/LinkButton.cs:122` </location>
<code_context>
private async Task OnClickButton()
{
- if (OnClickWithoutRender != null)
+ if (IsAsync)
{
- await OnClickWithoutRender();
+ IsAsyncLoading = true;
+ IsDisabled = true;
}
</code_context>
<issue_to_address>
Async state management added before click handling.
Check if IsAsyncLoading and IsDisabled remain accurate if HandlerClick throws an exception or completes synchronously.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6581 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 721 721
Lines 31559 31562 +3
Branches 4450 4450
=========================================
+ Hits 31559 31562 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Aug 15, 2025
This was referenced Aug 22, 2025
This was referenced Sep 3, 2025
This was referenced Sep 5, 2025
This was referenced Sep 15, 2025
This was referenced Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #6580
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Enable asynchronous click handling in LinkButton by introducing IsAsync with loading and disable state management, centralize click logic in ButtonBase, and update tests accordingly
New Features:
Enhancements:
Tests:
Chores: