Fix a bug in OutlinesCore backend about advancing when in final state#1727
Merged
RobinPicard merged 1 commit intomainfrom Aug 14, 2025
Merged
Fix a bug in OutlinesCore backend about advancing when in final state#1727RobinPicard merged 1 commit intomainfrom
RobinPicard merged 1 commit intomainfrom
Conversation
rlouf
approved these changes
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deals with the consequences of an issue in outlines-core
As described in the linked issue, there is a bug in outlines-core in which, when in a final position, the
eos_token_idis returned by theget_tokensmethod, but then causes an error if we try to advance through the guide with it! To avoid this problem, the outlines implementation used to simply check whether the current state is final, and stops advancing through the guide if that's the case. That causes another problem in case there are several different final states in the index, as we were not advancing through the guide even though a token leading to another final state was generated.The fix proposed here is to check whether the token last generated is accepted by the
accepts_tokensmethod to avoid advancing if theeos_token_idhas been generated (as before), but do advance through the guide in all other cases, especially when the token generated leads to a different final state.