Conversation
6a8bff8 to
abf39b8
Compare
rlouf
reviewed
Sep 26, 2025
Comment on lines
+374
to
+381
| target_types: List[Literal[ | ||
| "str", | ||
| "dict", | ||
| "pydantic", | ||
| "typeddict", | ||
| "dataclass", | ||
| "genson", | ||
| ]], |
Contributor
Author
There was a problem hiding this comment.
I thought it would be a more convenient interface to have only one method through which one can list all the types they support.
For instance:
if JsonSchema.is_json_schema(output_type):
return JsonSchema.convert_to(
output_type,
["dataclass", "typeddict", "pydantic"]
)
)672cdd1 to
bf5ab57
Compare
rlouf
approved these changes
Oct 3, 2025
bf5ab57 to
e1ae56a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #1722
This PR adds 2 class methods to the
JsonSchemaclass to check whether an object is a JSON schema type and to convert such an object to a different JSON schema typeThis change has 2 main objectives:
format_output_typemethods of the model type adapters. We want to push the complexity upstream such that the models only have to deal with theJsonSchemaclass instead of having to treat different JSON schema types itself