fix: Refactor sampling parameters in VLLMOffline to use StructuredOutputsParams #1779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for opening a PR! I'm traveling at the moment, I'll review it on Sunday. |
Contributor
Author
Have a wonderful trip! 🥳 |
RobinPicard
approved these changes
Nov 23, 2025
Contributor
RobinPicard
left a comment
RobinPicard
left a comment
There was a problem hiding this comment.
Thanks! The PR looks good, thanks a lot for taking care of this issue. I'll cut a patch release after merging. I just need to figure out what's going on with the tests
Contributor
|
The failing test is unrelated. I'll take of it separately. |
Contributor
Author
|
Great, thanks for the quick merge! Also, really appreciate you handling the test issues separately. 🤗 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1778