Fix a bug in the Transformers tokenizer#1817
Merged
RobinPicard merged 1 commit intomainfrom Feb 6, 2026
Merged
Conversation
Member
SauravMaheshkar
left a comment
SauravMaheshkar
left a comment
There was a problem hiding this comment.
Looks good as a fix, maybe we could double check if the bug is fixed by using the script from the original issue #1816?
Contributor
Author
|
Yes, it works as expected with the fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1816
The problem identified in the issue above comes from an incoherent handling of tokens containing a spiece underline. The
TransformerTokenizerclass was adding a white space to their string representation forLlamaTokenizer,tokenizers, but some models do not use it but still useSentencePiecetokenization that requires this transformation.We modify the
convert_token_to_stringmethod ofTransformerTokenizerto apply the adding of a white space in case of tokens starting with a speice underline for all tokenizers, considering nothing would happen for those that do not need it because they do not use the spiece underline.