fix(set-a11y-status): pass props.environment.document to getStatusDiv#755
Merged
silviuaavram merged 1 commit intomasterfrom Sep 5, 2019
Merged
fix(set-a11y-status): pass props.environment.document to getStatusDiv#755silviuaavram merged 1 commit intomasterfrom
silviuaavram merged 1 commit intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #755 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 3 3
Lines 418 418
Branches 105 105
=====================================
Hits 418 418
Continue to review full report at Codecov.
|
kolaps33
approved these changes
Sep 3, 2019
silviuaavram
force-pushed
the
fix/pass-document-to-a11y-status
branch
from
45ed3fc to
13b4fd0
Compare
jurokapsiar
approved these changes
Sep 5, 2019
silviuaavram
changed the title
Collaborator
Author
|
🎉 This PR is included in version 3.2.14 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Downshift already supports getting
environmentas prop and uses it throughout the component. It should also be passed to set-a11y-statussetStatusso that it will be used to create the status div in the correctdocument.