Added support for auto-creation of conda environments#170
Closed
jraviotta wants to merge 1 commit intodrivendataorg:masterfrom
jraviotta:environment
Closed
Added support for auto-creation of conda environments#170jraviotta wants to merge 1 commit intodrivendataorg:masterfrom jraviotta:environment
jraviotta wants to merge 1 commit intodrivendataorg:masterfrom
jraviotta:environment
Conversation
Member
|
Thanks for the interest in this feature @jraviotta! We're not going to merge this as-is, since we're moving to allowing the user to pick an option rather than bundling everything together. (see #162) If you want to test the changes on that branch with your |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is one possible resolution for #168 .
This PR updates the
Makefile requirementstarget with logic for selecting package and environment managers. If conda is detected, a conda environment is created and then updated with a newenvironment.ymlfile. If conda is not detected,requirements.txtis installed with pip and then an environment is created with virtualenv as before.The conda condition successfully creates the environment and the local package
srcis available in the jupyter kernel in jupyter lab. I can run the notebook cell described in #168 without an error.I have not tested the virtualenv condition as I am unfamiliar with it's normal behavior.