Skip to content

Fixed test_folders test to check for new folders in repository#196

Closed
ESKYoung wants to merge 1 commit intodrivendataorg:masterfrom
ESKYoung:patch-1
Closed

Fixed test_folders test to check for new folders in repository#196
ESKYoung wants to merge 1 commit intodrivendataorg:masterfrom
ESKYoung:patch-1

Conversation

@ESKYoung
Copy link

Changed from set difference to set symmetric difference. Test will now fail if there are more folders in the repository than listed in the expected_dirs variable.

Changed from set difference to set symmetric difference. Test will now
fail if there are more folders in the repository than listed in the
expected_dirs variable.
@pjbull
Copy link
Member

pjbull commented Feb 11, 2020

Thanks @ESKYoung. I'm actually rewriting the test suite in #162 right now where direct list comparisons in pytest give symmetric difference. Good catch though. Closing for now.

@pjbull pjbull closed this Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants