Remove config import from init to fix scaffold usage#372
Merged
Conversation
Member
The main thing that happens in |
Member
Author
Ah, that's a good point. Added back in. |
jayqi
approved these changes
May 30, 2024
chrisjkuch
approved these changes
May 30, 2024
Contributor
chrisjkuch
left a comment
There was a problem hiding this comment.
LGTM!
Just summarizing for my own understanding / posterity:
- We weren't appropriately removing
import configfrom__init__.pywhen we removed all the boilerplate code, which failed at import time becauseconfig.pyno longer existed - When the boilerplate was present, we weren't importing
configfrom the right place leading to an import error - We now import the config from the right place and remove it when boilerplate is removed, and we test that both of those work as expected in the live tests
Member
Author
Nailed it! 🔨 |
GatlenCulp
pushed a commit
to GatlenCulp/gatlens-opinionated-template
that referenced
this pull request
Jan 29, 2025
* Update config imports and test * reformat with latest black * Add config back in
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
__init__.py(not needed and also breaks since it is there in non-scaffold scenario)Closes #370