Merged
Conversation
chrisjkuch
commented
Feb 17, 2025
jayqi
reviewed
Feb 17, 2025
…and removing any module-level imports from pre-prompt
chrisjkuch
force-pushed
the
425-version-bugfix
branch
from
4157c7c to
131b123
Compare
pjbull
approved these changes
Feb 21, 2025
Member
pjbull
left a comment
pjbull
left a comment
There was a problem hiding this comment.
Change looks reasonable. How did you manually test different configs?
r-b-g-b
reviewed
Feb 21, 2025
Member
|
@chrisjkuch is this good to go? |
Contributor
Author
Member
|
@chrisjkuch is #416 really a blocker? It seems like (1) neither you nor I can reproduce it, and (2) if is is actually a problem, it's an unrelated specific bug that we could fix separately. |
Contributor
Author
Member
|
Yeah, let's do it! ✨ |
proinsias
added a commit
to proinsias/cookiecutter-data-science-proinsias
that referenced
this pull request
Nov 3, 2025
* upstream/master: (24 commits) Add poetry as an env manager (drivendataorg#460) Support pixi as environment manager (drivendataorg#459) Docs: Add guidelines for contributing and requesting tools (drivendataorg#456) Fix terminal animation generation in docs build (drivendataorg#451) Fix failing pipenv installation on Windows GH actions runners (drivendataorg#453) Fix typo in using-the-template.md (drivendataorg#448) Bump to v2.2.0 [skip ci] Update HISTORY.md [skip ci] Add option for tests (drivendataorg#447) Resolve python version to work with compatible operator (drivendataorg#446) Add pyproject.toml as a dependencies file option (drivendataorg#436) Make PyPI badges links to PyPI (drivendataorg#440) Update to version v2.1.0 (drivendataorg#438) Add back isort configuration that was removed in drivendataorg#387 (drivendataorg#439) add badges to readme and docs homepage (drivendataorg#434) Added support for the uv package and project manager (drivendataorg#408) Add ruff as default linting + formatting option (drivendataorg#387) Add PyTest IDs for better readability and filtering (drivendataorg#409) prepare for 2.0.1 release by bumping version in pyproject.toml and updating change log (drivendataorg#422) Fix pre-prompt ccds version error (drivendataorg#426) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue introduced in #336 (hotfixed in #427 ) that added a pre-prompt hook to warn about the newly introduced versioning system.
However, the pre-prompt script was unable to access certain module-level imports from the ccds package.
(I'm still trying to figure out / think about why that's the case)I think this is because we simultaneously changed the versioning structure and mechanism in #336 by adding aversion.pythat computed the package version, and people with the old version ofccdsinstalled were looking for the version ofccdsin a module that didn't exist in their version of the package.Migrating version extraction from a separate
version.pymodule into__init__.pyseems to fix this, since the version can be determined directly by importlib without needing separate imports from the ccds module.