Skip to content

fix: NoopTimer#time(Runnable) should run the Runnable #4541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joschi merged 1 commit into from
Oct 21, 2024
Merged

fix: NoopTimer#time(Runnable) should run the Runnable #4541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion metrics-core/src/main/java/io/dropwizard/metrics5/NoopMetricRegistry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,7 +468,7 @@ public <T> T timeSupplier(Supplier<T> event) {
*/
@Override
public void time(Runnable event) {
// NOP
event.run();
}

/**
Expand Down
10 changes: 10 additions & 0 deletions metrics-core/src/test/java/io/dropwizard/metrics5/NoopMetricRegistryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import java.util.HashMap;
import java.util.Map;
import java.util.Set;
import java.util.concurrent.atomic.AtomicBoolean;

import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatNullPointerException;
Expand Down Expand Up @@ -494,4 +495,13 @@ void registerNullMetric() {
.isThrownBy(() -> registry.register(MetricName.build("any_name"), null))
.withMessage("metric == null");
}

@Test
void timesRunnableInstances() {
Timer timer = registry.timer("thing");
final AtomicBoolean called = new AtomicBoolean();
timer.time(() -> called.set(true));

assertThat(called).isTrue();
}
}