Rescale threshold calculation#5169
Open
nickbar01234 wants to merge 1 commit intodropwizard:release/4.2.xfrom
Open
Rescale threshold calculation#5169nickbar01234 wants to merge 1 commit intodropwizard:release/4.2.xfrom
nickbar01234 wants to merge 1 commit intodropwizard:release/4.2.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted in #793, no new samples are recorded after ~13 hours as new priority returns infinity. This behavior is solved in #793. However, it's probably an unwanted behavior that we expose
alpha, but do not automatically calculate a rescale threshold.I've added a rescale threshold calculation if the upperbound is less than the
DEFAULT_RESCALE_THRESHOLDof 1 hour; otherwise, the old threshold is used to avoid any surprising behavioral change. If you're open to this change, I'll make the corresponding modifications inLockFreeExponentiallyDecayingReservoir.cc @arteam as you looked over the original issue