Update google music importer/exporter#1261
Merged
jzacsh merged 12 commits intodtinit:masterfrom Aug 24, 2023
Merged
Conversation
Collaborator
gauss0818
commented
Aug 8, 2023
gauss0818
commented
- Update type of GoogleTrack.duration due to json format.
- Update type of GooglePlaylist.createTime and GooglePlaylist.updateTime due to json format.
- Add patch request to GoogleMusicHttpApi
jzacsh
requested changes
Aug 23, 2023
...le/src/main/java/org/datatransferproject/datatransfer/google/musicModels/GooglePlaylist.java
Show resolved
Hide resolved
...gle/src/main/java/org/datatransferproject/datatransfer/google/music/GoogleMusicImporter.java
Outdated
Show resolved
Hide resolved
...gle/src/main/java/org/datatransferproject/datatransfer/google/music/GoogleMusicImporter.java
Outdated
Show resolved
Hide resolved
...ogle/src/main/java/org/datatransferproject/datatransfer/google/music/GoogleMusicHttpApi.java
Outdated
Show resolved
Hide resolved
...ogle/src/main/java/org/datatransferproject/datatransfer/google/music/GoogleMusicHttpApi.java
Outdated
Show resolved
Hide resolved
...gle/src/main/java/org/datatransferproject/datatransfer/google/music/GoogleMusicExporter.java
Show resolved
Hide resolved
…ldPatchRequest in GoogleMusicHttpApi
jzacsh
requested changes
Aug 23, 2023
...ogle/src/main/java/org/datatransferproject/datatransfer/google/music/GoogleMusicHttpApi.java
Outdated
Show resolved
Hide resolved
jzacsh
previously approved these changes
Aug 23, 2023
Collaborator
jzacsh
left a comment
jzacsh
left a comment
There was a problem hiding this comment.
just a question inlined for you as comment; feel free to change something or not.
...ogle/src/main/java/org/datatransferproject/datatransfer/google/music/GoogleMusicHttpApi.java
Outdated
Show resolved
Hide resolved
jzacsh
approved these changes
Aug 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.