Fix unreachable code warning for functions that return !#265
Merged
dtolnay merged 1 commit intodtolnay:masterfrom Apr 11, 2024
Merged
Fix unreachable code warning for functions that return !#265dtolnay merged 1 commit intodtolnay:masterfrom
!#265dtolnay merged 1 commit intodtolnay:masterfrom
Conversation
The generated code for function bodies produces an `unreachable_code`
warning if the function has a `!` return type.
The offending bit is:
```rust
if let Some(__ret) == None::<!> {
// unreachable
}
```
This PR fixes the warning by simply adding `#[allow(unreachable_code)]`
to the return statement. It also adds a test for it.
This problem can only be triggered on nightly with the `never_type`
feature enabled, but it is easy to fix here.
Owner
|
Published in async-trait 0.1.80. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generated code for function bodies produces an
unreachable_codewarning if the function has a!return type.The offending bit is:
This PR fixes the warning by simply adding
#[allow(unreachable_code)]to the return statement. It also adds a test for it.This problem can only be triggered on nightly with the
never_typefeature enabled, but it is easy to fix here.