refactor: cleanup code by duanyytop · Pull Request #147 · duanyytop/agents-radar

duanyytop · 2026-03-12T02:38:33Z

No description provided.

Copilot

Pull request overview

This PR refactors the report-generation pipeline to reduce duplication by centralizing bilingual (zh/en) strings, splitting prompt builders by domain, and extracting “save” logic into dedicated modules.

Changes:

Introduce src/i18n.ts as a centralized home for bilingual strings, labels, and issue title helpers, and wire it into report generation/notifications/manifest generation.
Split prompt builders into src/prompts.ts (repo-level) and src/prompts-data.ts (data-source + rollups), updating imports and tests accordingly.
Extract report saving (LLM call + file save + optional GitHub issue) into src/report-savers.ts, and consolidate sleep() into src/date.ts.

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
src/web.ts	Reuses shared `sleep()` from `date.ts`.
src/rollup.ts	Uses `prompts-data.ts` + i18n titles for weekly/monthly rollups.
src/report.ts	Uses centralized i18n footer text + shared `sleep()`.
src/report-savers.ts	New module extracting save/report/issue creation logic from `index.ts`.
src/report-builders.ts	Uses i18n titles/headings for CLI/OpenClaw report assembly.
src/prompts.ts	Keeps repo-level prompt builders and switches to `Lang` type from i18n.
src/prompts-data.ts	New module for trending/web/HN + weekly/monthly prompt builders.
src/notify.ts	Uses i18n-provided notification labels instead of inline maps.
src/index.ts	Orchestration updated to use extracted builders/savers and i18n helpers.
src/i18n.ts	New centralized bilingual strings, labels, and helper functions.
src/github.ts	Moves `LABEL_COLORS` to module scope for reuse/clarity.
src/generate-manifest.ts	Uses centralized `REPORT_LABELS` from i18n.
src/date.ts	Expands date utilities to include `sleep()`.
src/tests/prompt-builders.test.ts	Updates imports due to prompt module split.
src/tests/i18n.test.ts	Adds unit tests for i18n maps/helpers.
CLAUDE.md	Updates documentation to reflect new module split and i18n conventions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Copilot · 2026-03-12T02:43:18Z

src/rollup.ts

  const enContent =
-    `# AI Tools Ecosystem Weekly Report ${weekStr}\n\n` +
-    `> Coverage: ${last7[last7.length - 1]} ~ ${last7[0]} | Generated: ${utcStr} UTC\n\n` +
+    `# ${WEEKLY_REPORT.title.en} ${weekStr}\n\n` +
+    `> ${WEEKLY_REPORT.coverage.en}: ${last7[last7.length - 1]} ~ ${last7[0]} | Generated: ${utcStr} UTC\n\n` +
    `---\n\n` +


Weekly rollup EN output still hardcodes the timestamp label ("Generated") while the ZH output hardcodes "生成时间". Since bilingual strings are meant to be centralized in src/i18n.ts (CLAUDE.md:99), consider adding a WEEKLY_REPORT.generated (or shared) helper and using it here for both languages.

Copilot · 2026-03-12T02:43:19Z

src/rollup.ts

  const zhContent =
-    `# AI 工具生态月报 ${monthStr}\n\n` +
+    `# ${MONTHLY_REPORT.title.zh} ${monthStr}\n\n` +
    `> 数据来源: ${sourceLabel.zh} | 生成时间: ${utcStr} UTC\n\n` +
    `---\n\n` +
    zhSummary +
    footer;

  const enContent =
-    `# AI Tools Ecosystem Monthly Report ${monthStr}\n\n` +
+    `# ${MONTHLY_REPORT.title.en} ${monthStr}\n\n` +
    `> Sources: ${sourceLabel.en} | Generated: ${utcStr} UTC\n\n` +
    `---\n\n` +


Monthly rollup output still hardcodes bilingual strings inline ("Sources"/"数据来源", "Generated"/"生成时间"). To match the new i18n convention (CLAUDE.md:99), please move these labels into src/i18n.ts (e.g., MONTHLY_REPORT.sourcesLabel/generated helper) and reference them here.

Copilot · 2026-03-12T02:43:19Z

src/prompts-data.ts

+      if (newItems.length === 0) return `## ${siteName}\n\n（${mode}，暂无可供分析的内容。）`;
+
+      const unableToExtract = lang === "en" ? "(Unable to extract text content)" : "（无法提取文本内容）";
+      const itemsText = newItems
+        .map((item) =>
+          [
+            `### [${item.title || item.url}](${item.url})`,
+            `- 分类: ${item.category} | 发布/更新: ${item.lastmod.slice(0, 10) || "未知"}`,
+            `- 内容节选: ${item.content || unableToExtract}`,
+          ].join("\n"),
+        )
+        .join("\n\n");
+
+      return `## ${siteName}（${mode}）\n\n${itemsText}`;


buildWebReportPrompt mixes Chinese-only labels even when lang === "en" (e.g., "（${mode}，暂无可供分析的内容。）", "分类", "发布/更新", "内容节选", and Chinese parentheses in the section header). This makes the English prompt internally inconsistent and can degrade LLM output quality. Please provide English equivalents when lang === "en".

Suggested change

if (newItems.length === 0) return `## ${siteName}\n\n（${mode}，暂无可供分析的内容。）`;

const unableToExtract = lang === "en" ? "(Unable to extract text content)" : "（无法提取文本内容）";

const itemsText = newItems

.map((item) =>

[

`### [${item.title || item.url}](${item.url})`,

`- 分类: ${item.category} | 发布/更新: ${item.lastmod.slice(0, 10) || "未知"}`,

`- 内容节选: ${item.content || unableToExtract}`,

].join("\n"),

)

.join("\n\n");

return `## ${siteName}（${mode}）\n\n${itemsText}`;

if (newItems.length === 0) {

return lang === "en"

? `## ${siteName}\n\n(${mode}, no content available for analysis.)`

: `## ${siteName}\n\n（${mode}，暂无可供分析的内容。）`;

}

const unableToExtract = lang === "en" ? "(Unable to extract text content)" : "（无法提取文本内容）";

const itemsText = newItems

.map((item) =>

[

`### [${item.title || item.url}](${item.url})`,

lang === "en"

? `- Category: ${item.category} | Published/Updated: ${item.lastmod.slice(0, 10) || "Unknown"}`

: `- 分类: ${item.category} | 发布/更新: ${item.lastmod.slice(0, 10) || "未知"}`,

lang === "en"

? `- Content excerpt: ${item.content || unableToExtract}`

: `- 内容节选: ${item.content || unableToExtract}`,

].join("\n"),

)

.join("\n\n");

return lang === "en"

? `## ${siteName} (${mode})\n\n${itemsText}`

: `## ${siteName}（${mode}）\n\n${itemsText}`;

Copilot · 2026-03-12T02:43:19Z

src/prompts-data.ts

+        ? `${i + 1}. **${s.title}**\n` +
+          `   Link: ${s.url}\n` +
+          `   Discussion: ${s.hnUrl}\n` +
+          `   Score: ${s.points} | Comments: ${s.comments} | Author: @${s.author} | 时间: ${s.createdAt.slice(0, 16)}`


In the English HN prompt, the story metadata line still contains a Chinese label ("时间"). This should be English (e.g., "Time") when lang === "en" to keep the prompt language consistent.

Suggested change

` Score: ${s.points} | Comments: ${s.comments} | Author: @${s.author} | 时间: ${s.createdAt.slice(0, 16)}`

` Score: ${s.points} | Comments: ${s.comments} | Author: @${s.author} | Time: ${s.createdAt.slice(0, 16)}`

Copilot · 2026-03-12T02:43:19Z

src/report-savers.ts

+  const fileName = lang === "en" ? "ai-trending-en.md" : "ai-trending.md";
+  const header =
+    `# ${TRENDING_REPORT.title[lang]} ${dateStr}\n\n` +
+    `> ${TRENDING_REPORT.sources[lang]} | ${lang === "en" ? "Generated" : "生成时间"}: ${utcStr} UTC\n\n---\n\n`;


In the trending report header, the timestamp label is still selected via an inline zh/en ternary ("Generated" vs "生成时间"). This conflicts with the repo convention to centralize bilingual strings in src/i18n.ts (see CLAUDE.md:99). Please move this label (or a full TRENDING_REPORT.meta/header helper) into i18n.ts and reference it here.

Suggested change

`> ${TRENDING_REPORT.sources[lang]} | ${lang === "en" ? "Generated" : "生成时间"}: ${utcStr} UTC\n\n---\n\n`;

`> ${TRENDING_REPORT.sources[lang]} | ${TRENDING_REPORT.generatedLabel[lang]}: ${utcStr} UTC\n\n---\n\n`;

Copilot · 2026-03-12T02:43:20Z

src/report-savers.ts

+    const header =
+      lang === "en"
+        ? `# ${HN_REPORT.title[lang]} ${dateStr}\n\n` +
+          `> Source: [Hacker News](https://news.ycombinator.com/) | ` +
+          `${hnData.stories.length} stories | Generated: ${utcStr} UTC\n\n` +
+          `---\n\n`
+        : `# ${HN_REPORT.title[lang]} ${dateStr}\n\n` +
+          `> 数据来源: [Hacker News](https://news.ycombinator.com/) | ` +
+          `共 ${hnData.stories.length} 条 | 生成时间: ${utcStr} UTC\n\n` +
+          `---\n\n`;


The HN report header still hardcodes several bilingual strings via a large lang === "en" ? ... : ... block ("Source", "Generated", "stories", etc.). Per the repo convention (CLAUDE.md:99), these should be centralized in src/i18n.ts (e.g., HN_REPORT.meta/header helper) to avoid scattered translation logic.

Copilot · 2026-03-12T02:43:20Z

src/report-builders.ts

+  const meta =
    lang === "en"
-      ? {
-          title: `# OpenClaw Ecosystem Digest ${dateStr}\n\n`,
-          meta: `> Issues: ${issues.length} | PRs: ${prs.length} | Projects covered: ${1 + openclawPeers.length} | Generated: ${utcStr} UTC\n\n`,
-          deepDive: `## OpenClaw Deep Dive\n\n`,
-          comparison: `## Cross-Ecosystem Comparison\n\n`,
-          peers: `## Peer Project Reports\n\n`,
-        }
-      : {
-          title: `# OpenClaw 生态日报 ${dateStr}\n\n`,
-          meta: `> Issues: ${issues.length} | PRs: ${prs.length} | 覆盖项目: ${1 + openclawPeers.length} 个 | 生成时间: ${utcStr} UTC\n\n`,
-          deepDive: `## OpenClaw 项目深度报告\n\n`,
-          comparison: `## 横向生态对比\n\n`,
-          peers: `## 同赛道项目详细报告\n\n`,
-        };
+      ? `> Issues: ${issues.length} | PRs: ${prs.length} | Projects covered: ${1 + openclawPeers.length} | Generated: ${utcStr} UTC\n\n`
+      : `> Issues: ${issues.length} | PRs: ${prs.length} | 覆盖项目: ${1 + openclawPeers.length} 个 | 生成时间: ${utcStr} UTC\n\n`;


OpenClaw report metadata is still built with an inline zh/en ternary ("Generated"/"生成时间", "Projects covered"/"覆盖项目"). This reintroduces inline bilingual strings; please add an OPENCLAW_REPORT.meta helper in src/i18n.ts (similar to CLI_REPORT.meta) and use it here to follow CLAUDE.md:99.

duanyytop added 9 commits March 12, 2026 10:02

refactor: centralize i18n strings into src/i18n.ts

f40ea1c

refactor: extract report savers from index.ts

86d91ae

refactor: deduplicate zh/en report generation in main()

76c20fd

refactor: use Lang type consistently in prompts.ts

1ff4d58

test: add i18n module tests

9bf707b

refactor: deduplicate sleep(), hoist LABEL_COLORS

4a553b8

refactor: move REPORT_LABELS to i18n.ts

6e1aff9

refactor: split prompts.ts into repo and data-source modules

1c00e1e

docs: update claude document

f3121f9

duanyytop requested a review from Copilot March 12, 2026 02:38

Copilot started reviewing on behalf of duanyytop March 12, 2026 02:39 View session

Copilot AI reviewed Mar 12, 2026

View reviewed changes

fix: use English labels in EN prompts for web and HN reports

4d26832

duanyytop merged commit d57961d into master Mar 12, 2026
1 check passed

duanyytop deleted the refactor/cleanup branch March 12, 2026 03:18

github-actions bot mentioned this pull request Mar 27, 2026

📊 AI CLI Tools Digest 2026-03-27 jstamagal/agents-radar#130

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: cleanup code#147

refactor: cleanup code#147
duanyytop merged 10 commits intomasterfrom
refactor/cleanup

duanyytop commented Mar 12, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 12, 2026

Uh oh!

Copilot AI Mar 12, 2026

Uh oh!

Copilot AI Mar 12, 2026

Uh oh!

Copilot AI Mar 12, 2026

Uh oh!

Copilot AI Mar 12, 2026

Uh oh!

Copilot AI Mar 12, 2026

Uh oh!

Copilot AI Mar 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	` Score: ${s.points} \| Comments: ${s.comments} \| Author: @${s.author} \| 时间: ${s.createdAt.slice(0, 16)}`
	` Score: ${s.points} \| Comments: ${s.comments} \| Author: @${s.author} \| Time: ${s.createdAt.slice(0, 16)}`

	`> ${TRENDING_REPORT.sources[lang]} \| ${lang === "en" ? "Generated" : "生成时间"}: ${utcStr} UTC\n\n---\n\n`;
	`> ${TRENDING_REPORT.sources[lang]} \| ${TRENDING_REPORT.generatedLabel[lang]}: ${utcStr} UTC\n\n---\n\n`;

Conversation

duanyytop commented Mar 12, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants