Skip to content

Comments

✨ REVERT-6040: Self-referencing capabilities from letrec#6334

Merged
dubzzz merged 2 commits intomainfrom
revert-letrec
Dec 6, 2025
Merged

✨ REVERT-6040: Self-referencing capabilities from letrec#6334
dubzzz merged 2 commits intomainfrom
revert-letrec

Conversation

@dubzzz
Copy link
Owner

@dubzzz dubzzz commented Dec 6, 2025

Description

Going back to the code of letrec from 4.3.0 while keeping part of the code improvements added since that addition.

Reverting #6040. We are working on a new option in #6333.

ChecklistDon't delete this checklist and make sure you do the following before opening the PR

  • The name of my PR follows gitmoji specification
  • My PR references one of several related issues (if any)
    • New features or breaking changes must come with an associated Issue or Discussion
    • My PR does not add any new dependency without an associated Issue or Discussion
  • My PR includes bumps details, please run pnpm run bump and flag the impacts properly
  • My PR adds relevant tests and they would have failed without my PR (when applicable)

Advanced

  • Category: ...
  • Impacts: ...

Going back to the code of `letrec` from 4.3.0 while keeping part of the code improvements added since that addition.

Reverting #6040. We are working on a new option in #6333.
@changeset-bot
Copy link

changeset-bot bot commented Dec 6, 2025

⚠️ No Changeset found

Latest commit: d2c44fa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dubzzz dubzzz enabled auto-merge (squash) December 6, 2025 21:00
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2025

👋 A preview of the new documentation is available at: http://693499f2d2d0bb955449ec69--dubzzz-fast-check.netlify.app

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 6, 2025

@fast-check/ava

npm i https://pkg.pr.new/@fast-check/ava@6334

@fast-check/expect-type

npm i https://pkg.pr.new/@fast-check/expect-type@6334

fast-check

npm i https://pkg.pr.new/fast-check@6334

@fast-check/jest

npm i https://pkg.pr.new/@fast-check/jest@6334

@fast-check/packaged

npm i https://pkg.pr.new/@fast-check/packaged@6334

@fast-check/poisoning

npm i https://pkg.pr.new/@fast-check/poisoning@6334

@fast-check/vitest

npm i https://pkg.pr.new/@fast-check/vitest@6334

@fast-check/worker

npm i https://pkg.pr.new/@fast-check/worker@6334

commit: d2c44fa

@dubzzz dubzzz merged commit 09ef663 into main Dec 6, 2025
33 checks passed
@dubzzz dubzzz deleted the revert-letrec branch December 6, 2025 21:07
@codecov
Copy link

codecov bot commented Dec 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.85%. Comparing base (612649d) to head (d2c44fa).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6334      +/-   ##
==========================================
- Coverage   94.97%   94.85%   -0.12%     
==========================================
  Files         201      201              
  Lines        5368     5324      -44     
  Branches     1417     1406      -11     
==========================================
- Hits         5098     5050      -48     
- Misses        258      261       +3     
- Partials       12       13       +1     
Flag Coverage Δ
tests 94.85% <100.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant