Open
Conversation
Adds GBA boxart, also amended game&watch as it does not use CRC, but filename matching like DOOM.
Used an updated pngquant, which resulted in roughly a 20% filesize reduction with little to none effects on image quality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi
This adds GBA boxart, all CRC checked. Confirmed working on my device, it isnt that fast but I assume it takes longer to CRC check bigger roms! but works much faster when cached.
Also amended gw as it does not use CRC, it matches the filename like DOOM so deleted the CRC versions and added as filenames.
No worries if you want to wait until GBA is more official before you merge, or if you dont want to merge, I'll keep them on my fork.
Thanks
P.S. I have also done A2600, NGP & WS as it was easier to do while I was doing GBA, its not in this pull request. I've just assumed they will use the whole CRC, no offsetting like NES/Lynx. If that isnt the case, I can amend.