Update ESLint to v10.0.2#66
Update ESLint to v10.0.2#66Art Chaidarun (artnc) wants to merge 1 commit intoupdate-dependenciesfrom
Conversation
Art Chaidarun (artnc)
force-pushed
the
update-eslint-to-v1002
branch
4 times, most recently
from
51e500c to
ea912dd
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ea912dd866
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "codex (@codex) address that feedback".
| [HookName.Prettier]: { | ||
| action: sources => run("prettier", ...PRETTIER_OPTIONS, ...sources), | ||
| include: /\.(css|html?|markdown|md|scss|tsx?|ya?ml)$/, | ||
| include: /\.(css|html?|markdown|md|mjs|scss|tsx?|ya?ml)$/, |
There was a problem hiding this comment.
Adding mjs to the Prettier hook means .mjs sources are now part of the formatting pipeline, but the ESLint hook still only matches /\.[jt]sx?$/, so those files skip ESLint entirely. In this change that includes the renamed eslint.config.mjs, which previously received ESLint autofixes when it was .js; repos with ESM .mjs files will now get only Prettier formatting and miss ESLint-based fixes (for example import/object ordering rules).
Useful? React with 👍 / 👎.
Art Chaidarun (artnc)
force-pushed
the
update-eslint-to-v1002
branch
from
ea912dd to
b5f2557
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b5f255753c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "codex (@codex) address that feedback".
| }, | ||
| exclude: MINIFIED_JS_REGEX, | ||
| include: /\.[jt]sx?$/, | ||
| include: /\.(mjs|[jt]sx?)$/, |
There was a problem hiding this comment.
entry.ts now sends .mjs files to ESLint (include: /\.(mjs|[jt]sx?)$/), but the only flat-config block in eslint.config.mjs is still scoped to files: ["**/*.{js,jsx,ts,tsx}"], so .mjs inputs are effectively linted with no rules and receive no ESLint autofixes. This means the new .mjs coverage is currently a no-op (including for eslint.config.mjs itself), which undermines the migration intent and can leave .mjs files inconsistently formatted compared with .js/.ts files.
Useful? React with 👍 / 👎.
Art Chaidarun (artnc)
force-pushed
the
update-eslint-to-v1002
branch
3 times, most recently
from
c23a268 to
96567e2
Compare
Art Chaidarun (artnc)
force-pushed
the
update-eslint-to-v1002
branch
from
96567e2 to
ddf9418
Compare
1 participant
No description provided.