fix: eloquent model import#202
Closed
badasukerubin wants to merge 1 commit intodurable-workflow:masterfrom
Closed
Conversation
Member
|
That is actually intentional and how it's meant to loaded. That's because some packages like MongoDB do not extend the Eloquent models. Thank you for the PR anyways. I appreciate the time and effort you took to make it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for this great package.
When I tested the package within another Laravel package, I got
Class "Workflow\Models\Model" not found.I was able to temporarily circumvent the issue by creating an alias in the package's
ServiceProviderie:, but it'd be nice not to get the error at all.