Child workflow signaling#290
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #290 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 316 323 +7
===========================================
Files 46 47 +1
Lines 1327 1355 +28
===========================================
+ Hits 1327 1355 +28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rmcdaniel
pushed a commit
that referenced
this pull request
Apr 17, 2026
…tional
The v2 section of config/workflows.php used bare env() calls for
WORKFLOW_V2_NAMESPACE, the three WORKFLOW_V2_*_COMPATIBILITY keys, and
the two WORKFLOW_V2_HISTORY_EXPORT_SIGNING_KEY keys. That reads like
required configuration; the runtime already tolerates null for all six
(WorkerCompatibility, HistoryExport signing, and namespace scoping each
treat null as "disabled"). Make that explicit so fresh installs do not
appear broken.
- Pass null as the second env() argument on all six keys so the
default behavior is documented at the config site, not implicit.
- Add inline comments explaining the "null = disabled" semantics and
pointing to when each key becomes useful (multi-namespace isolation,
pinned worker builds, authenticated history exports).
- Add a new WorkflowsConfigTest case that unsets those six env vars
and asserts the config still loads with null values and retains the
defaulted numeric/string fallbacks (heartbeat_ttl_seconds, queue
dispatch mode, guardrails boot mode).
Also update the avro data set in CodecIndependentHelpersTest to use
serializeWithCodec/unserializeWithCodec: __callStatic('unserialize')
sniffs the blob by first byte and cannot auto-detect binary Avro. The
codec-explicit path is how persistence layers round-trip Avro blobs in
production.
Closes #290.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a safe mechanism for parent workflows to signal their children through two new features:
1. ChildWorkflowHandle Class
A new
ChildWorkflowHandleclass that wraps a child workflow and provides context-safe signaling:__call()magic method to forward any signal method to the child2. Workflow Methods:
child()andchildren()Two new methods added to the base
Workflowclass:child(): Returns aChildWorkflowHandlefor the most recently created child workflow at the current execution indexchildren(): Returns an array ofChildWorkflowHandleinstances for all child workflows at the current execution indexBoth methods are deterministic - they filter children by
parent_index <= $this->index, ensuring consistent results during workflow replay.Usage Examples
Example 1: Parent Directly Signals Child
Example 2: Parent Forwards External Signal to Child